Add a new Channel API for experimental plugins feature #5141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
changed the title
Mm2PL
force-pushed
the
feature/lua-channel-api
branch
from
411ee63
to
786782d
Compare
Mm2PL
force-pushed
the
feature/lua-channel-api
branch
from
786782d
to
59f13d2
Compare
Wissididom
reviewed
Feb 2, 2024
docs/chatterino.d.ts
Outdated
Comment on lines
36
to
45
| class Channel implements IWeakResource { | ||
| is_valid(): boolean; | ||
| get_name(): string; | ||
| get_type(): ChannelType; | ||
| get_display_name(): string; | ||
| is_twitch_channel(): boolean; | ||
|
|
||
| static by_name(name: string, platform: Platform): null | Channel; | ||
| static by_twitch_id(id: string): null | Channel; | ||
| } |
There was a problem hiding this comment.
Isn't there send_message and add_system_message missing, because send_msg and system_msg were removed a few lines below this class definition and in the plugin-meta.lua there are those functions defined as member of Channel?
There was a problem hiding this comment.
They are missing, thank you for reminding me of that
pajlada
reviewed
Feb 3, 2024
…erino2 into feature/lua-channel-api
…re/lua-channel-api
pajlada
approved these changes
Feb 3, 2024
devJimmyboy
pushed a commit
to devJimmyboy/chatterino7
that referenced
this pull request
Feb 11, 2024
|
I saw this PR just now and noticed two things:
|
|
@4rneee Could you create an issue to track that? Super helpful feedback |
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example usage:
When Chatterino deletes the Channel, all lua ChannelRefs to it expire and using them will produce an error. It is possible to check for this before using those functions with
Channel:is_valid(). I expect that other weak objects will have identical methods, I created IWeakResource interface class which defines this method.Breaking
This PR removes
c2.system_msgandc2.send_msg.